ben-roling commented on a change in pull request #666: HADOOP-16221 add option to fail operation on metadata write failure URL: https://github.com/apache/hadoop/pull/666#discussion_r276068285
########## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AMetadataPersistenceException.java ########## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.s3a; + +import static org.apache.hadoop.test.LambdaTestUtils.intercept; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.doThrow; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Collection; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FSDataOutputStream; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.s3a.s3guard.MetadataStore; +import org.apache.hadoop.fs.s3a.s3guard.PathMetadata; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import org.mockito.Mockito; + +/** + * Tests failed writes to metadata store generate the expected + * MetadataPersistenceException. + */ +@RunWith(Parameterized.class) +public class ITestS3AMetadataPersistenceException extends AbstractS3ATestBase { + private S3AFileSystem fs; + private MetadataStore originalMetadataStore; + private IOException ioException; + private final boolean failOnError; + + public ITestS3AMetadataPersistenceException(boolean failOnError) { + this.failOnError = failOnError; + } + + @Parameterized.Parameters + public static Collection<Object[]> params() { + return Arrays.asList(new Object[][]{ + {true}, + {false} + }); + } + + @Override + protected Configuration createConfiguration() { + Configuration conf = super.createConfiguration(); + conf.set(Constants.FAIL_ON_METADATA_WRITE_ERROR, + Boolean.toString(failOnError)); + return conf; + } + + @Before + public void setUp() throws Exception { + fs = getFileSystem(); + originalMetadataStore = fs.getMetadataStore(); + ioException = new IOException(); + } + + @After + public void tearDown() { + fs.setMetadataStore(originalMetadataStore); + } + + private void useIOExceptionMetadataStore() throws IOException { + MetadataStore metadataStoreSpy = Mockito.spy(originalMetadataStore); + doThrow(ioException).when(metadataStoreSpy) + .put(any(PathMetadata.class)); + fs.setMetadataStore(metadataStoreSpy); + } + + @Test + public void testFailedMetadataUpdate() throws Throwable { + // write a trivial file + Path testFile = path("testFile"); + FSDataOutputStream outputStream = fs.create(testFile); + outputStream.write(1); + + useIOExceptionMetadataStore(); + + if (failOnError) { + // close should throw the expected exception + Exception thrown = intercept(MetadataPersistenceException.class, () -> { + outputStream.close(); + }); + assertTrue("expected MetadataPersistenceException wasn't thrown", Review comment: Updated in https://github.com/apache/hadoop/pull/666/commits/8ff542741ab3386a9ce967fb2f36fab2265413f4 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
