[
https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831905#comment-16831905
]
Íñigo Goiri commented on HADOOP-16266:
--------------------------------------
I don't have fundamental comments.
I like the use of nanos all over and just converting to whatever the admin sets.
Minor comments:
* In {{RpcScheduler#addResponseTime}}, I would extract the variables. Easier to
have high level names.
* In the second {{RpcScheduler#addResponseTime}}, it would be good to clarify
the use of the deprecated method (kind of confusing to have one deprecated and
the other one using it).
* In {{Server}} use the logger style for the warning. Not sure if it needs the
{{isWarnEnabled()}} using {}.
* Fix the spacing for the comment in {{Server#750}}.
* In the debug message for {{Server#2931}}, can we leverage the logger format
to some degree? All the %s could be {}.
* Can we make {{RpcMetrics#TIMEUNIT}} configurable? Now we would have to change
code.
* In the {{Metrics.md}} we could mention that the units now are configurable
and not always millseconds.
* In {{RpcMetrics}} can we remove the old {{//@Override}}?
* Add some high level comments to the tests in {{TestProcessingDetails}}.
* Can we do some testing using the {{lockAndSleep()}} for the unit conversion?
> Add more fine-grained processing time metrics to the RPC layer
> --------------------------------------------------------------
>
> Key: HADOOP-16266
> URL: https://issues.apache.org/jira/browse/HADOOP-16266
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Christopher Gregorian
> Assignee: Christopher Gregorian
> Priority: Minor
> Labels: rpc
> Attachments: HADOOP-16266.001.patch, HADOOP-16266.002.patch,
> HADOOP-16266.003.patch, HADOOP-16266.004.patch, HADOOP-16266.005.patch,
> HADOOP-16266.006.patch, HADOOP-16266.007.patch, HADOOP-16266.008.patch
>
>
> Splitting off of HDFS-14403 to track the first part: introduces more
> fine-grained measuring of how a call's processing time is split up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
