[ 
https://issues.apache.org/jira/browse/HADOOP-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063949#comment-13063949
 ] 

Alejandro Abdelnur commented on HADOOP-6671:
--------------------------------------------

Giri,

Thanks for playing with the patch.

Actually the layout after applying the patch (Maven module speaking) is:

{code}
trunk/pom.xml
|
|-- doclet/pom.xml
|
|-- root/pom.xml
|
|-- common-main/pom.xml
|      |
|      |-- common/pom.xml
|      |
|      |-- docs/pom.xml
|      |
|      |-- distro/pom.xml
|
|-- hdfs
|
|-- mapreduce
{code}

I assume you are testing it in a SVN checkout, the old common dir (empty) won't 
go away till you commit.

The reason for calling the root Common 'common-main' and the child one 'common' 
is to be as close as possible to the artifact names (generated JARs).

We could also go the way of using the full artifact names, then it could be:

{code}
trunk/pom.xml
|
|-- hadoop-doclet/pom.xml
|
|-- hadoop-root/pom.xml
|
|-- common/pom.xml
|      |
|      |-- hadoop-common/pom.xml
|      |
|      |-- hadoop-common-docs/pom.xml
|      |
|      |-- hadoop-common-distro/pom.xml
|
|-- hdfs
|
|-- mapreduce
{code}

This seemed to verbose to me, that is way I didn't go that path initially.

Thoughts?


> To use maven for hadoop common builds
> -------------------------------------
>
>                 Key: HADOOP-6671
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6671
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Giridharan Kesavan
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-6671-cross-project-HDFS.patch, 
> HADOOP-6671-e.patch, HADOOP-6671-f.patch, HADOOP-6671-g.patch, 
> HADOOP-6671-h.patch, HADOOP-6671-i.patch, HADOOP-6671-j.patch, 
> HADOOP-6671-k.sh, HADOOP-6671-l.patch, HADOOP-6671-m.patch, 
> HADOOP-6671.patch, HADOOP-6671b.patch, HADOOP-6671c.patch, 
> HADOOP-6671d.patch, build.png, common-mvn-layout-i.sh, 
> hadoop-commons-maven.patch, mvn-layout-e.sh, mvn-layout-f.sh, 
> mvn-layout-k.sh, mvn-layout-l.sh, mvn-layout-m.sh, mvn-layout.sh, 
> mvn-layout.sh, mvn-layout2.sh, mvn-layout2.sh
>
>
> We are now able to publish hadoop artifacts to the maven repo successfully [ 
> Hadoop-6382]
> Drawbacks with the current approach:
> * Use ivy for dependency management with ivy.xml
> * Use maven-ant-task for artifact publishing to the maven repository
> * pom files are not generated dynamically 
> To address this I propose we use maven to build hadoop-common, which would 
> help us to manage dependencies, publish artifacts and have one single xml 
> file(POM) for dependency management and artifact publishing.
> I would like to have a branch created to work on mavenizing  hadoop common.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to