[ https://issues.apache.org/jira/browse/HADOOP-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835586#comment-16835586 ]
Hadoop QA commented on HADOOP-16248: ------------------------------------ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color} | {color:red} HADOOP-16248 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HADOOP-16248 | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/16237/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Fix MutableQuantiles memory leak > -------------------------------- > > Key: HADOOP-16248 > URL: https://issues.apache.org/jira/browse/HADOOP-16248 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.9.2 > Reporter: Alexis Daboville > Priority: Major > Attachments: mutable-quantiles-leak.png, mutable-quantiles.patch > > > In some circumstances (high GC, high CPU usage, creating lots of > S3AFileSystem) it is possible for MutableQuantiles::scheduler [1] to fall > behind processing tasks that are submitted to it; because tasks are > submitted on a regular schedule, the unbounded queue backing the > {{ExecutorService}} might grow to several gigs [2]. By using > {{scheduleWithFixedDelay}} instead, we ensure that under pressure this leak > won't > happen. In order to mitigate the growth, a simple fix [3] is proposed, > simply replacing {{scheduler.scheduleAtFixedRate}} by > {{scheduler.scheduleWithFixedDelay}}. > [1] it is single threaded and shared across all instances of > {{MutableQuantiles}}: > [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java#L66-L68] > [2] see attached mutable-quantiles-leak.png. > [3] mutable-quantiles.patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org