hanishakoneru commented on a change in pull request #798: HDDS-1499.
OzoneManager Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r282215862
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/utils/db/TestTypedRDBTableStore.java
##########
@@ -236,4 +249,66 @@ public void forEachAndIterator() throws Exception {
}
}
}
+
+ @Test
+ public void testTypedTableWithCache() throws Exception {
+ int iterCount = 10;
+ try (Table<String, String> testTable = createTypedTableWithCache(
+ "Seven", TableCache.CACHETYPE.FULLCACHE)) {
+
+ for (int x = 0; x < iterCount; x++) {
+ String key = Integer.toString(x);
+ String value = Integer.toString(x);
+ testTable.addCacheEntry(new CacheKey<>(key), new CacheValue<>(value,
+ CacheValue.OperationType.CREATED, x));
+ }
+
+ // As we have added to cache, so get should return value even if it
+ // does not exist in DB.
+ for (int x = 0; x < iterCount; x++) {
+ Assert.assertEquals(Integer.toString(1),
+ testTable.get(Integer.toString(1)));
+ }
+
+ }
+ }
+
+ @Test
+ public void testTypedTableWithCacheWithFewDeletedOperationType()
+ throws Exception {
+ int iterCount = 10;
+ try (Table<String, String> testTable = createTypedTableWithCache(
+ "Seven", TableCache.CACHETYPE.PARTIALCACHE)) {
+
+ for (int x = 0; x < iterCount; x++) {
+ String key = Integer.toString(x);
+ String value = Integer.toString(x);
+ if (x % 2 == 0) {
+ testTable.addCacheEntry(new CacheKey<>(key),
+ new CacheValue<>(value,
+ CacheValue.OperationType.CREATED, x));
+ } else {
+ testTable.addCacheEntry(new CacheKey<>(key), new CacheValue<>(value,
+ CacheValue.OperationType.DELETED, x));
+ }
+ }
+
+ // As we have added to cache, so get should return value even if it
+ // does not exist in DB.
+ for (int x = 0; x < iterCount; x++) {
+ if (x % 2 == 0) {
+ Assert.assertEquals(Integer.toString(x),
+ testTable.get(Integer.toString(x)));
+ } else {
+ Assert.assertNull(testTable.get(Integer.toString(x)));
+ }
+ }
+
+ testTable.cleanupCache(5);
+
+ GenericTestUtils.waitFor(() ->
+ ((TypedTable<String, String>) testTable).getCache().size() == 4,
+ 100, 5000);
+ }
Review comment:
Can we also check that the cache entries remaining in the cache are the
expected entries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
