bharatviswa504 commented on a change in pull request #798: HDDS-1499. 
OzoneManager Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r284364154
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
 ##########
 @@ -245,42 +247,50 @@ protected DBStoreBuilder 
addOMTablesAndCodecs(DBStoreBuilder builder) {
    */
   protected void initializeOmTables() throws IOException {
     userTable =
-        this.store.getTable(USER_TABLE, String.class, VolumeList.class);
+        this.store.getTable(USER_TABLE, String.class, VolumeList.class,
 
 Review comment:
   As for some tables where SCM does not need to have cache, so that is the 
reason for introducing CacheType.
   And also for some tables like deletedtable, where this is used by background 
thread inOM, these does not need cache.
   
   And as for volume/bucket table we plan to have entire table info, and 
cleanup for them is no-op, even after flush to db, where as for partial cache 
the cache entries will be cleaned up. This is the only difference between full 
table cache vs partial table cache.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to