bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r285305076
########## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ########## @@ -106,6 +142,40 @@ public void close() throws Exception { } + @Override + public void addCacheEntry(CacheKey<KEY> cacheKey, + CacheValue<VALUE> cacheValue) { + // This will override the entry if there is already entry for this key. + cache.put(cacheKey, cacheValue); + } + + + @Override + public void cleanupCache(long epoch) { Review comment: This is added because, in actual usage of classes, we get Table reference, and they can simply call table.cleanupCache(). Added getCache() is used only for testing, so declared it as not a public method and annotated with VisibleForTesting. And usage of this will be in the code, once double-buffer integration is completed. Let me know if you still want to be removed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org