ajayydv commented on a change in pull request #828: HDDS-1538. Update ozone
protobuf message for ACLs. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/828#discussion_r285699438
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.java
##########
@@ -47,16 +52,37 @@ public OzoneAcl() {
*
* @param type - Type
* @param name - Name of user
- * @param rights - Rights
+ * @param acl - Rights
*/
- public OzoneAcl(OzoneACLType type, String name, OzoneACLRights rights) {
+ public OzoneAcl(ACLIdentityType type, String name, ACLType acl) {
this.name = name;
- this.rights = rights;
+ this.rights = new ArrayList<>();
+ this.rights.add(acl);
this.type = type;
- if (type == OzoneACLType.WORLD && name.length() != 0) {
+ if (type == ACLIdentityType.WORLD && name.length() != 0) {
throw new IllegalArgumentException("Unexpected name part in world type");
}
- if (((type == OzoneACLType.USER) || (type == OzoneACLType.GROUP))
+ if (((type == ACLIdentityType.USER) || (type == ACLIdentityType.GROUP))
+ && (name.length() == 0)) {
+ throw new IllegalArgumentException("User or group name is required");
+ }
+ }
+
+ /**
+ * Constructor for OzoneAcl.
+ *
+ * @param type - Type
+ * @param name - Name of user
+ * @param acls - Rights
+ */
+ public OzoneAcl(ACLIdentityType type, String name, List<ACLType> acls) {
+ this.name = name;
+ this.rights = acls;
+ this.type = type;
+ if (type == ACLIdentityType.WORLD && name.length() != 0) {
Review comment:
Logic is taken from existing constructor. I think intention is to have a
name when type if GROUP and USER but not when it is WORLD.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
