[ https://issues.apache.org/jira/browse/HADOOP-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066706#comment-13066706 ]
Hadoop QA commented on HADOOP-2081: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486773/HADOOP-2081.r3.diff against trunk revision 1147317. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/739//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/739//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/739//console This message is automatically generated. > Configuration getInt, getLong, and getFloat replace invalid numbers with the > default value > ------------------------------------------------------------------------------------------ > > Key: HADOOP-2081 > URL: https://issues.apache.org/jira/browse/HADOOP-2081 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Affects Versions: 0.22.0 > Reporter: Owen O'Malley > Assignee: Harsh J > Fix For: 0.23.0 > > Attachments: HADOOP-2081.r1.diff, HADOOP-2081.r2.diff, > HADOOP-2081.r3.diff > > > The current behavior of silently replace invalid numbers in the configuration > with the default value leads to hard to diagnose problems. The methods should > throw an exception to signal that the input was invalid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira