hadoop-yetus commented on a change in pull request #1002: HDDS-1716. Smoketest
results are generated with an internal user
URL: https://github.com/apache/hadoop/pull/1002#discussion_r296221307
##########
File path: hadoop-ozone/dist/src/main/compose/testlib.sh
##########
@@ -75,10 +75,14 @@ execute_robot_test(){
CONTAINER="$1"
TEST="$2"
TEST_NAME=$(basename "$TEST")
- TEST_NAME=${TEST_NAME%.*}
+ TEST_NAME="$(basename $COMPOSE_DIR)-${TEST_NAME%.*}"
set +e
OUTPUT_NAME="$COMPOSE_ENV_NAME-$TEST_NAME-$CONTAINER"
+ docker-compose -f "$COMPOSE_FILE" exec -T "$CONTAINER" mkdir -p
"$RESULT_DIR_INSIDE"
docker-compose -f "$COMPOSE_FILE" exec -e
SECURITY_ENABLED="${SECURITY_ENABLED}" -T "$CONTAINER" python -m robot --log
NONE -N "$TEST_NAME" --report NONE "${OZONE_ROBOT_OPTS[@]}" --output
"$RESULT_DIR_INSIDE/robot-$OUTPUT_NAME.xml" "$SMOKETEST_DIR_INSIDE/$TEST"
+
+ export FULL_CONTAINER_NAME=$(docker-compose -f "$COMPOSE_FILE" ps | grep
"_${CONTAINER}_" | head -n 1 | awk '{print $1}')
Review comment:
shellcheck:10: warning: Declare and assign separately to avoid masking
return values. [SC2155]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
