[
https://issues.apache.org/jira/browse/HADOOP-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874262#comment-16874262
]
Erik Krogen commented on HADOOP-16391:
--------------------------------------
[~vinayakumarb], I see what you mean, that's a good find. Basically the
{{init()}} is setting up metrics for declared methods on the interface, so even
if you don't use the deferred response feature, it will emit a duplicate
metric. Removing the method from the interface just makes the initialization
functionality not work properly, and also I'm hesitant to tamper with any
protocol definitions. I think the right solution here is to make {{init()}}
accept a {{String prefix}} parameter which indicates that the method names on
the protocol should be prefixed. We can reuse the same prefix here as well as
when calling {{add()}} to make the names match.
{quote}
This will be the correct fix. But I am afraid, whether this will be considered
as incompatible change?
Or should we say, user might be picking wrong metric all along because of
duplicate metrics, this will be fixed now and not an 'incompatible' change?
{quote}
As I understand it, currently the deferred RPC metrics are basically unusable
because they exactly match the metric names of the non-deferred calls, making
them indistinguishable. I think we can safely change this name.
> Duplicate values in rpcDetailedMetrics
> --------------------------------------
>
> Key: HADOOP-16391
> URL: https://issues.apache.org/jira/browse/HADOOP-16391
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bilwa S T
> Assignee: Bilwa S T
> Priority: Major
> Attachments: image-2019-06-25-20-30-15-395.png, screenshot-1.png,
> screenshot-2.png
>
>
> In RpcDetailedMetrics init is called two times . Once for deferredRpcrates
> and other one rates metrics which causes duplicate values in RM and NM
> metrics.
> !image-2019-06-25-20-30-15-395.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
