arp7 commented on issue #1044: HDDS-1731. Implement File CreateFile Request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1044#issuecomment-508183660 The patch looks mostly fine to me. A few minor comments and one type error that needs to be fixed. I would like to see the class hierarchy refactored in a follow up patch. `OMFileCreateRequest` should not extend `OMKeyCreateRequest`. Instead they should both extend an abstract class that encapsulates the common functionality. Generally deriving from _concrete_ classes is a bad idea.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
