swagle commented on a change in pull request #1055: HDDS-1705. Recon: Add
estimatedTotalCount to the response of ...
URL: https://github.com/apache/hadoop/pull/1055#discussion_r300188797
##########
File path:
hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestContainerKeyMapperTask.java
##########
@@ -73,33 +82,67 @@
private ReconOMMetadataManager reconOMMetadataManager;
private Injector injector;
private OzoneManagerServiceProviderImpl ozoneManagerServiceProvider;
+ private boolean setUpIsDone = false;
+
+ private Injector getInjector() {
+ return injector;
+ }
@Before
public void setUp() throws Exception {
omMetadataManager = initializeNewOmMetadataManager();
- injector = Guice.createInjector(new AbstractModule() {
- @Override
- protected void configure() {
- try {
- bind(OzoneConfiguration.class).toInstance(
- getTestOzoneConfiguration());
-
- reconOMMetadataManager = getTestMetadataManager(omMetadataManager);
-
bind(ReconOMMetadataManager.class).toInstance(reconOMMetadataManager);
- ozoneManagerServiceProvider = new OzoneManagerServiceProviderImpl(
- getTestOzoneConfiguration());
- bind(OzoneManagerServiceProvider.class)
- .toInstance(ozoneManagerServiceProvider);
-
- bind(DBStore.class).toProvider(ReconContainerDBProvider.class).
- in(Singleton.class);
- bind(ContainerDBServiceProvider.class).to(
- ContainerDBServiceProviderImpl.class).in(Singleton.class);
- } catch (IOException e) {
- Assert.fail();
+
+ File tempDir = temporaryFolder.newFolder();
+ AbstractSqlDatabaseTest.DataSourceConfigurationProvider
+ configurationProvider =
+ new AbstractSqlDatabaseTest.DataSourceConfigurationProvider(tempDir);
+
+ JooqPersistenceModule jooqPersistenceModule =
+ new JooqPersistenceModule(configurationProvider);
+
+ injector = Guice.createInjector(jooqPersistenceModule,
Review comment:
Isn't this code duplicated? Can we add an interface with default impl which
is support in Java 8? Or a static helper somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
