[
https://issues.apache.org/jira/browse/HADOOP-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882330#comment-16882330
]
Erik Krogen commented on HADOOP-16418:
--------------------------------------
I added the suppression for the JavadocStyle check before the comment as you
suggested. Nice find.
I fixed the {{BlockInfo}} FindBugs and also cleaned up that class a bit; there
was quite a bit of dead code hanging around.
I pulled out some helper methods for the long method warning. For the
{{AMOptions}} constructor, I don't see an issue with the parameter number --
the constructor is just used internally to be able to create the object. I
added a suppression and marked the constructor private.
> Fix checkstyle and findbugs warnings in hadoop-dynamometer
> ----------------------------------------------------------
>
> Key: HADOOP-16418
> URL: https://issues.apache.org/jira/browse/HADOOP-16418
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools
> Reporter: Masatake Iwasaki
> Assignee: Erik Krogen
> Priority: Minor
> Attachments: HADOOP-16418.000.patch, HADOOP-16418.001.patch,
> HADOOP-16418.002.patch, HADOOP-16418.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
