bharatviswa504 commented on a change in pull request #948: HDDS-1649. On installSnapshot notification from OM leader, download checkpoint and reload OM state URL: https://github.com/apache/hadoop/pull/948#discussion_r305039875
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java ########## @@ -159,15 +159,18 @@ public void decNumKeys() { } public void setNumVolumes(long val) { - this.numVolumes.incr(val); + long oldVal = this.numVolumes.value(); + this.numVolumes.incr(val - oldVal); Review comment: Then why do we do this this.numVolumes.incr(val - oldVal); Sorry still not got it why are we doing this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org