[ https://issues.apache.org/jira/browse/HADOOP-16445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891640#comment-16891640 ]
Siddharth Seth commented on HADOOP-16445: ----------------------------------------- bq. github PRs are how we're reviewing patches no. Will move this over to a PR bq. No tests, no review, you know the rules. The patch does have what I think are unit tests. Do you have some specific tests in mind (integration tests?) and pointers on where to add them. A possible test would be to set up a custom signer via the new configs and use it. bq. Which endpoint did you test against, and, for something going anywhere near auth, I'm expecting the SSE-KMS and IAM roles to be tested to, including the role delegation tokens. thanks Not sure why SSE-KMS, IAM roles and delegation tokens need to be tested on this patch (HADOOP-16449 is the one which makes changes to the way authN tokens can be specified). The patch allows for custom signers, and does not change authentication mechanics. > Allow separate custom signing algorithms for S3 and DDB > ------------------------------------------------------- > > Key: HADOOP-16445 > URL: https://issues.apache.org/jira/browse/HADOOP-16445 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/s3 > Reporter: Siddharth Seth > Assignee: Siddharth Seth > Priority: Major > Attachments: HADOOP-16445.01.patch, HADOOP-16445.02.patch > > > fs.s3a.signing-algorithm allows overriding the signer. This applies to both > the S3 and DDB clients. Need to be able to specify separate signing algorithm > overrides for S3 and DDB. > -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org