sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve
fsimage load time by writing sub-sections to the fsimage index
URL: https://github.com/apache/hadoop/pull/1028#discussion_r306736414
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
##########
@@ -389,21 +496,26 @@ private void loadErasureCodingSection(InputStream in)
public static final class Saver {
public static final int CHECK_CANCEL_INTERVAL = 4096;
+ public static boolean WRITE_SUB_SECTIONS = false;
Review comment:
I agree we should make this change. I was originally copying the pattern
set by CHECK_CANCEL_INTERVAL, but best to avoid the constants I think. I have
made this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
