hadoop-yetus commented on issue #1166: HDDS-1856. Merge HA and Non-HA code in OM. URL: https://github.com/apache/hadoop/pull/1166#issuecomment-515292094 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 101 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 25 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 683 | trunk passed | | +1 | compile | 391 | trunk passed | | +1 | checkstyle | 76 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 1037 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 174 | trunk passed | | 0 | spotbugs | 431 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 630 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 594 | the patch passed | | +1 | compile | 388 | the patch passed | | +1 | javac | 388 | the patch passed | | +1 | checkstyle | 81 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 745 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 171 | the patch passed | | -1 | findbugs | 442 | hadoop-ozone generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0) | ||| _ Other Tests _ | | -1 | unit | 329 | hadoop-hdds in the patch failed. | | -1 | unit | 2408 | hadoop-ozone in the patch failed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 8680 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-ozone | | | Inconsistent synchronization of org.apache.hadoop.ozone.om.ratis.OzoneManagerDoubleBuffer.readyFutureQueue; locked 50% of time Unsynchronized access at OzoneManagerDoubleBuffer.java:50% of time Unsynchronized access at OzoneManagerDoubleBuffer.java:[line 171] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.bucket.OMBucketCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMBucketCreateRequest.java:in org.apache.hadoop.ozone.om.request.bucket.OMBucketCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMBucketCreateRequest.java:[line 175] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.bucket.OMBucketDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMBucketDeleteRequest.java:in org.apache.hadoop.ozone.om.request.bucket.OMBucketDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMBucketDeleteRequest.java:[line 140] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.bucket.OMBucketSetPropertyRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMBucketSetPropertyRequest.java:in org.apache.hadoop.ozone.om.request.bucket.OMBucketSetPropertyRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMBucketSetPropertyRequest.java:[line 186] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.file.OMDirectoryCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMDirectoryCreateRequest.java:in org.apache.hadoop.ozone.om.request.file.OMDirectoryCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMDirectoryCreateRequest.java:[line 194] | | | Possible null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.file.OMDirectoryCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) Dereferenced at OMDirectoryCreateRequest.java:omClientResponse in org.apache.hadoop.ozone.om.request.file.OMDirectoryCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) Dereferenced at OMDirectoryCreateRequest.java:[line 194] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.file.OMFileCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMFileCreateRequest.java:in org.apache.hadoop.ozone.om.request.file.OMFileCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMFileCreateRequest.java:[line 283] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.key.OMKeyCommitRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyCommitRequest.java:in org.apache.hadoop.ozone.om.request.key.OMKeyCommitRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyCommitRequest.java:[line 170] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.key.OMKeyCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyCreateRequest.java:in org.apache.hadoop.ozone.om.request.key.OMKeyCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyCreateRequest.java:[line 199] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.key.OMKeyDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyDeleteRequest.java:in org.apache.hadoop.ozone.om.request.key.OMKeyDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyDeleteRequest.java:[line 157] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.key.OMKeyRenameRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyRenameRequest.java:in org.apache.hadoop.ozone.om.request.key.OMKeyRenameRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMKeyRenameRequest.java:[line 179] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.s3.bucket.S3BucketCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3BucketCreateRequest.java:in org.apache.hadoop.ozone.om.request.s3.bucket.S3BucketCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3BucketCreateRequest.java:[line 228] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.s3.bucket.S3BucketDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3BucketDeleteRequest.java:in org.apache.hadoop.ozone.om.request.s3.bucket.S3BucketDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3BucketDeleteRequest.java:[line 154] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.s3.multipart.S3InitiateMultipartUploadRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3InitiateMultipartUploadRequest.java:in org.apache.hadoop.ozone.om.request.s3.multipart.S3InitiateMultipartUploadRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3InitiateMultipartUploadRequest.java:[line 193] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.s3.multipart.S3MultipartUploadAbortRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3MultipartUploadAbortRequest.java:in org.apache.hadoop.ozone.om.request.s3.multipart.S3MultipartUploadAbortRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3MultipartUploadAbortRequest.java:[line 152] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.s3.multipart.S3MultipartUploadCommitPartRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3MultipartUploadCommitPartRequest.java:in org.apache.hadoop.ozone.om.request.s3.multipart.S3MultipartUploadCommitPartRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at S3MultipartUploadCommitPartRequest.java:[line 209] | | | Possible null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.volume.OMVolumeCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeCreateRequest.java:omClientResponse in org.apache.hadoop.ozone.om.request.volume.OMVolumeCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeCreateRequest.java:[line 160] | | | Possible null pointer dereference of omVolumeArgs in org.apache.hadoop.ozone.om.request.volume.OMVolumeCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeCreateRequest.java:omVolumeArgs in org.apache.hadoop.ozone.om.request.volume.OMVolumeCreateRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeCreateRequest.java:[line 173] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.volume.OMVolumeDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeDeleteRequest.java:in org.apache.hadoop.ozone.om.request.volume.OMVolumeDeleteRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeDeleteRequest.java:[line 137] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.volume.OMVolumeSetOwnerRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeSetOwnerRequest.java:in org.apache.hadoop.ozone.om.request.volume.OMVolumeSetOwnerRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeSetOwnerRequest.java:[line 180] | | | Null pointer dereference of omClientResponse in org.apache.hadoop.ozone.om.request.volume.OMVolumeSetQuotaRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeSetQuotaRequest.java:in org.apache.hadoop.ozone.om.request.volume.OMVolumeSetQuotaRequest.validateAndUpdateCache(OzoneManager, long, OzoneManagerDoubleBufferHelper) on exception path Dereferenced at OMVolumeSetQuotaRequest.java:[line 143] | | Failed junit tests | hadoop.ozone.om.TestOmAcls | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.om.TestSecureOzoneManager | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1166/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1166 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux c06225d7ede9 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 6b8107a | | Default Java | 1.8.0_212 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1166/2/artifact/out/new-findbugs-hadoop-ozone.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1166/2/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1166/2/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1166/2/testReport/ | | Max. process+thread count | 5353 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1166/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
