bharatviswa504 commented on a change in pull request #1147: HDDS-1619. Support
volume acl operations for OM HA. Contributed by…
URL: https://github.com/apache/hadoop/pull/1147#discussion_r309527672
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerHARequestHandlerImpl.java
##########
@@ -70,6 +70,7 @@ public OMResponse handleApplyTransaction(OMRequest omRequest,
case CreateS3Bucket:
case DeleteS3Bucket:
case InitiateMultiPartUpload:
+ case AddAcl:
Review comment:
Yes, But when addAcl/removeAcl/setAcl comes for bucket which is not handled,
so for them we should call normal handler.handle. So, here we need to have
below code
`
if (omClientRequest != null) { OMClientResponse omClientResponse =
omClientRequest.validateAndUpdateCache(getOzoneManager(),
transactionLogIndex, ozoneManagerDoubleBuffer::add);
} else {
return handle(omClientRequest);
}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
