[ 
https://issues.apache.org/jira/browse/HADOOP-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated HADOOP-7525:
------------------------------

    Attachment: HADOOP-7525.patch

Here's a patch for this.
* I checked and test-patch.sh already uses smart-apply-patch.sh
* I removed the curl option since it wasn't used.
* I also added a {{--dirty-workspace}} that allows the workspace to have 
uncommitted changes in it. This is useful if you need to move some files around 
in SVN before applying your patch. It's also useful for testing changes to 
test-patch.sh itself.

Usage:
{noformat}
Usage: dev-support/test-patch.sh [options] patch-file | defect-number

Where:
  patch-file is a local patch file containing the changes to test
  defect-number is a JIRA defect number (e.g. 'HADOOP-1234') to test (Jenkins 
only)

Options:
--patch-dir=<dir>      The directory for working and output files (default 
'/tmp')
--basedir=<dir>        The directory to apply the patch to (default current 
directory)
--mvn-cmd=<cmd>        The 'mvn' command to use (default $MAVEN_HOME/bin/mvn, 
or 'mvn')
--ps-cmd=<cmd>         The 'ps' command to use (default 'ps')
--awk-cmd=<cmd>        The 'awk' command to use (default 'awk')
--svn-cmd=<cmd>        The 'svn' command to use (default 'svn')
--grep-cmd=<cmd>       The 'grep' command to use (default 'grep')
--patch-cmd=<cmd>      The 'patch' command to use (default 'patch')
--findbugs-home=<path> Findbugs home directory (default FINDBUGS_HOME 
environment variable)
--forrest-home=<path>  Forrest home directory (default FORREST_HOME environment 
variable)
--dirty-workspace      Allow the local SVN workspace to have uncommitted changes

Jenkins-only options:
--jenkins              Run by Jenkins (runs tests and posts results to JIRA)
--support-dir=<dir>    The directory to find support files in
--wget-cmd=<cmd>       The 'wget' command to use (default 'wget')
--jira-cmd=<cmd>       The 'jira' command to use (default 'jira')
--jira-password=<pw>   The password for the 'jira' command
--eclipse-home=<path>  Eclipse home directory (default ECLIPSE_HOME environment 
variable)
{noformat}

> Make arguments to test-patch optional
> -------------------------------------
>
>                 Key: HADOOP-7525
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7525
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: scripts
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-7525.patch
>
>
> Currently you have to specify all the arguments to test-patch.sh, which makes 
> it cumbersome to use. We should make all arguments except the patch file 
> optional. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to