hadoop-yetus commented on issue #1314: HDFS-14748. Make DataNodePeerMetrics#minOutlierDetectionSamples configurable URL: https://github.com/apache/hadoop/pull/1314#issuecomment-523892597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 49 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1106 | trunk passed | | +1 | compile | 55 | trunk passed | | +1 | checkstyle | 53 | trunk passed | | +1 | mvnsite | 65 | trunk passed | | +1 | shadedclient | 753 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 51 | trunk passed | | 0 | spotbugs | 160 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 158 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 57 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | -0 | checkstyle | 39 | hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 607 unchanged - 0 fixed = 608 total (was 607) | | +1 | mvnsite | 57 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedclient | 721 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 44 | the patch passed | | -1 | findbugs | 158 | hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | -1 | unit | 4939 | hadoop-hdfs in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 8436 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-hdfs-project/hadoop-hdfs | | | Write to static field org.apache.hadoop.hdfs.server.datanode.metrics.DataNodePeerMetrics.minOutlierDetectionSamples from instance method new org.apache.hadoop.hdfs.server.datanode.metrics.DataNodePeerMetrics(String, Configuration) At DataNodePeerMetrics.java:from instance method new org.apache.hadoop.hdfs.server.datanode.metrics.DataNodePeerMetrics(String, Configuration) At DataNodePeerMetrics.java:[line 70] | | Failed junit tests | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | | | hadoop.hdfs.server.datanode.TestDataNodeMetrics | | | hadoop.hdfs.qjournal.server.TestJournalNodeSync | | | hadoop.hdfs.server.balancer.TestBalancer | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1314/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1314 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux e574db6f146f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / ee7c261 | | Default Java | 1.8.0_222 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1314/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1314/2/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1314/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1314/2/testReport/ | | Max. process+thread count | 4117 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1314/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
