adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317652114
########## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopFsValidator.java ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.ozone.freon; + +import java.net.URI; +import java.security.MessageDigest; +import java.util.concurrent.Callable; + +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hdds.cli.HddsVersionProvider; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; + +import com.codahale.metrics.Timer; +import org.apache.commons.io.IOUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import picocli.CommandLine.Command; +import picocli.CommandLine.Option; + +/** + * Data generator tool test om performance. + */ +@Command(name = "dfsv", + aliases = "dfs-file-validator", + description = "Validate if the generated files have the same hash.", + versionProvider = HddsVersionProvider.class, + mixinStandardHelpOptions = true, + showDefaultValues = true) +public class HadoopFsValidator extends BaseFreonGenerator + implements Callable<Void> { + + private static final Logger LOG = + LoggerFactory.getLogger(HadoopFsValidator.class); + + @Option(names = {"--path"}, + description = "Hadoop FS file system path", + defaultValue = "o3fs://bucket1.vol1") + private String rootPath; + + private ContentGenerator contentGenerator; + + private Timer timer; + + private FileSystem fileSystem; + + private byte[] referenceDigest; + + @Override + public Void call() throws Exception { + + init(); + + OzoneConfiguration configuration = createOzoneConfiguration(); + + fileSystem = FileSystem.get(URI.create(rootPath), configuration); + + Path file = new Path(rootPath + "/" + generateObjectName(0)); + try (FSDataInputStream stream = fileSystem.open(file)) { + referenceDigest = getDigest(stream); + } + + timer = getMetrics().timer("gile-read"); Review comment: ```suggestion timer = getMetrics().timer("file-read"); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
