steveloughran commented on a change in pull request #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#discussion_r319115905
########## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java ########## @@ -3770,19 +3731,54 @@ public LocatedFileStatus next() throws IOException { @Retries.RetryTranslated public RemoteIterator<S3ALocatedFileStatus> listFilesAndEmptyDirectories( Path f, boolean recursive) throws IOException { - return invoker.retry("list", f.toString(), true, - () -> innerListFiles(f, recursive, new Listing.AcceptAllButS3nDirs())); + return innerListFiles(f, recursive, Listing.ACCEPT_ALL_BUT_S3N, null, true); } - @Retries.OnceTranslated - private RemoteIterator<S3ALocatedFileStatus> innerListFiles(Path f, boolean - recursive, Listing.FileStatusAcceptor acceptor) throws IOException { + /** + * List files under the path. + * <ol> + * <li> + * If the path is authoritative, only S3Guard will be queried. Review comment: clarified this is client-side ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org