[
https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086020#comment-13086020
]
Tsz Wo (Nicholas), SZE commented on HADOOP-7493:
------------------------------------------------
- There is a warning: WritableComparable is a raw type. References to generic
type WritableComparable<T> should be parameterized
- Why converting shorts to ints?
{code}
+ int thisValue = (short) readUnsignedShort(b1, s1);
+ int thatValue = (short) readUnsignedShort(b2, s2);
{code}
- Please add @Override tags.
- There are many tailing spaces in the license header. Please remove them.
> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
> Key: HADOOP-7493
> URL: https://issues.apache.org/jira/browse/HADOOP-7493
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7493.1.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
