[ https://issues.apache.org/jira/browse/HADOOP-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-6889: -------------------------------- Attachment: HADOOP-6889-fortrunk.patch HADOOP-6889-for-20security.patch The tests included with the previous patch was not testing the exact corresponding change. Hence, a new patch for tests are included (both for trunk and branch-20-security): ----------------------------------------- branch-20-security patch-test results as follows: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 7 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] --------------------------------------- trunk patch-test results: It was failing on empty patch as well for release audit and system test framework. [exec] BUILD FAILED [exec] /home/johngeo/hadoop/trunk/hdfs/src/test/aop/build/aop.xml:222: The following error occurred while executing this nclude 8 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The apline: [exec] /home/johngeo/hadoop/trunk/hdfs/src/test/aop/build/aop.xml:203: The following error occurred while executing this line: [exec] /hplied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any nome/johngeo/hadoop/trunk/hdfs/src/test/aop/build/aop.xml:90: compile errors: 18 [exec] [exec] Total time: 35 seconds [exec] ew Findbugs (version 1.3.9) warnings. [exec] [exec] -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 0 warnings). [exec] [exec] -1 system test framework. The patch failed system test framework compile. > Make RPC to have an option to timeout > ------------------------------------- > > Key: HADOOP-6889 > URL: https://issues.apache.org/jira/browse/HADOOP-6889 > Project: Hadoop Common > Issue Type: New Feature > Components: ipc > Affects Versions: 0.22.0 > Reporter: Hairong Kuang > Assignee: John George > Fix For: 0.20-append, 0.20.205.0, 0.22.0 > > Attachments: HADOOP-6889-for-20security.patch, > HADOOP-6889-for20.2.patch, HADOOP-6889-for20.3.patch, > HADOOP-6889-for20.patch, HADOOP-6889-fortrunk.patch, HADOOP-6889.patch, > ipcTimeout.patch, ipcTimeout1.patch, ipcTimeout2.patch > > > Currently Hadoop RPC does not timeout when the RPC server is alive. What it > currently does is that a RPC client sends a ping to the server whenever a > socket timeout happens. If the server is still alive, it continues to wait > instead of throwing a SocketTimeoutException. This is to avoid a client to > retry when a server is busy and thus making the server even busier. This > works great if the RPC server is NameNode. > But Hadoop RPC is also used for some of client to DataNode communications, > for example, for getting a replica's length. When a client comes across a > problematic DataNode, it gets stuck and can not switch to a different > DataNode. In this case, it would be better that the client receives a timeout > exception. > I plan to add a new configuration ipc.client.max.pings that specifies the max > number of pings that a client could try. If a response can not be received > after the specified max number of pings, a SocketTimeoutException is thrown. > If this configuration property is not set, a client maintains the current > semantics, waiting forever. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira