sodonnel commented on a change in pull request #1344: HDDS-1982 Extend
SCMNodeManager to support decommission and maintenance states
URL: https://github.com/apache/hadoop/pull/1344#discussion_r321197327
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##########
@@ -426,18 +432,20 @@ public int getStaleNodeCount() {
* @return dead node count
*/
public int getDeadNodeCount() {
- return getNodeCount(NodeState.DEAD);
+ // TODO - hard coded IN_SERVICE
+ return getNodeCount(
+ new NodeStatus(NodeOperationalState.IN_SERVICE, NodeState.DEAD));
Review comment:
There are a bunch of places where I have hardcoded IN_SERVICE, so once we
get this working we will need different events for DECOM / IN_MAINT + DEAD, as
that is an expected state rather than an error condition as it would be now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
