xiaoyuyao commented on a change in pull request #1373: HDDS-2053. Fix
TestOzoneManagerRatisServer failure. Contributed by Xi…
URL: https://github.com/apache/hadoop/pull/1373#discussion_r321472474
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java
##########
@@ -205,6 +205,7 @@ public void
verifyRaftGroupIdGenerationWithCustomOmServiceId() throws
.setOMServiceId(customOmServiceId)
.build();
// Starts a single node Ratis server
+ omRatisServer.stop();
OzoneManagerRatisServer newOmRatisServer = OzoneManagerRatisServer
Review comment:
@ChenSammi omRatisServer is started at the begin of each test case and stop
after that. However in this new test case, it started a different
OzoneManagerRatisServer named newOmRatisServer, it has to be stopped explicitly
to avoid leak. Also, the omRatisServer has to be stopped to avoid metric
registration failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
