[ 
https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924033#comment-16924033
 ] 

Vinayakumar B commented on HADOOP-13363:
----------------------------------------

Initial commit I forgot  about updating the build environment for specific 
protoc executable.

 In the latest commit, I have updated "hadoop-maven-plugin" to download protoc 
executable dynamically from maven repo similar to  
"org.xolstice.maven.plugins:protobuf-maven-plugin". (Borrowed the artifact 
resolution code from the protobuf-maven-plugin).

 

I have verified the compilation using both 3.6.0 and 3.6.1 protoc executables. 
3.6.0 is installed version locally. 3.6.1 was downloaded from maven repo.

Tried to test with 3.7.1 as well. But this have again compilation issues in 
Generated Builder code.

So, sticking to 3.6.1 should be good IMO.

 

Waiting for the latest results from 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1408/

> Upgrade protobuf from 2.5.0 to something newer
> ----------------------------------------------
>
>                 Key: HADOOP-13363
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13363
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-alpha1, 3.0.0-alpha2
>            Reporter: Allen Wittenauer
>            Assignee: Vinayakumar B
>            Priority: Major
>              Labels: security
>         Attachments: HADOOP-13363.001.patch, HADOOP-13363.002.patch, 
> HADOOP-13363.003.patch, HADOOP-13363.004.patch, HADOOP-13363.005.patch
>
>
> Standard protobuf 2.5.0 does not work properly on many platforms.  (See, for 
> example, https://gist.github.com/BennettSmith/7111094 ).  In order for us to 
> avoid crazy work arounds in the build environment and the fact that 2.5.0 is 
> starting to slowly disappear as a standard install-able package for even 
> Linux/x86, we need to either upgrade or self bundle or something else.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to