smengcl commented on a change in pull request #1360: HDDS-2007. Make ozone fs
shell command work with OM HA service ids
URL: https://github.com/apache/hadoop/pull/1360#discussion_r321904661
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneClientFactory.java
##########
@@ -136,6 +136,31 @@ public static OzoneClient getRpcClient(String omHost,
Integer omRpcPort,
return getRpcClient(config);
}
+ /**
+ * Returns an OzoneClient which will use RPC protocol.
+ *
+ * @param omServiceId
+ * Service ID of OzoneManager HA cluster.
+ *
+ * @param config
+ * Configuration to be used for OzoneClient creation
+ *
+ * @return OzoneClient
+ *
+ * @throws IOException
+ */
+ public static OzoneClient getRpcClient(String omServiceId,
+ Configuration config)
+ throws IOException {
+ Preconditions.checkNotNull(omServiceId);
+ Preconditions.checkNotNull(config);
+ // Override ozone.om.address just in case it is used later.
+ // Because if this is not overridden, the (incorrect) value from xml
+ // will be used?
+ config.set(OZONE_OM_ADDRESS_KEY, omServiceId);
Review comment:
As discussed, I will remove this one. Thanks for pointing out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
