[ 
https://issues.apache.org/jira/browse/HADOOP-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087047#comment-13087047
 ] 

Robert Joseph Evans commented on HADOOP-7532:
---------------------------------------------

Luke,  I do have to say that starting out with Hamlet was confusing for me.  I 
did not ask for help because I usually will read through all the documentation 
I can for the libraries I am using and even resort to reading through the 
source code for those libraries before I ask for help.  It is probably a bad 
habit of mine, but I find that I gain a much more in depth knowledge of the 
library and its potential quirks then just having someone tell me to copy and 
paste those classes over there and change these fields.

In relation to your comment about progressive enhancement I do not see how 
forcing all java script on the page to go through the top level view improves 
progressive enhancement.  I understand that you want to separate the structure 
from the code,  I totally agree with that.  The point of separating the 
structure from the code is so that if java script is not available then the 
page will still render.  It may not offer all of the functionality that would 
otherwise be available but it renders.  Progressive enhancement then goes off 
and in the java script adds in more functionality piece by piece based off of 
what the browser supports.

Yes the top level view does need to be able to help with the initialization, 
but I think a lot of these problems are coming from trying to delay 
instantiation of a SubView until it is rendered.  I would rather see the sub 
views created prerender then initialized and finally rendered.

Another nit that comes to my mind now also is with CSS and that TwoColumnLayout 
uses table to place elements in different locations on the page.  I thought 
that using table to do layout was an HTML anti-pattern. I don't know what 
browsers we are targeting so I cannot really say if it is necessary or not for 
proper layout.  However it is such basic CSS that getting it to be supported on 
all browsers that JQuery supports should not be that difficult.

> Hadoop web UI 2.0
> -----------------
>
>                 Key: HADOOP-7532
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7532
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Luke Lu
>            Assignee: Luke Lu
>             Fix For: 0.23.0
>
>
> People have expressed interests of bringing Hadoop web UI up to date with the 
> lightweight embedded web mvc framework used in MAPREDUCE-279 (cf. 
> MAPREDUCE-2399). This is the umbrella jira for UI improvement for 0.23+. 
> Individual items like web framework refactor/move and the unique challenge 
> for MR2 webapp security will be filed separately.
> Thoughts/ideas on various improvement of Hadoop web UI are welcome here. Some 
> of the ideas will naturally become sub-issues.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to