bgaborg commented on a change in pull request #1407: HADOOP-16490. Improve
S3Guard handling of FNFEs in copy
URL: https://github.com/apache/hadoop/pull/1407#discussion_r322217284
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
##########
@@ -761,4 +761,29 @@ private Constants() {
* Default change detection require version: true.
*/
public static final boolean CHANGE_DETECT_REQUIRE_VERSION_DEFAULT = true;
+
+ /**
+ * Number of times to retry any repeatable S3 client request on failure,
+ * excluding throttling requests: {@value}.
+ */
+ public static final String S3GUARD_CONSISTENCY_RETRY_LIMIT =
+ "fs.s3a.s3guard.consistency.retry.limit";
+
+ /**
+ * Default retry limit: {@value}.
+ */
+ public static final int S3GUARD_CONSISTENCY_RETRY_LIMIT_DEFAULT = 7;
+
+ /**
+ * Initial retry interval: {@value}.
+ */
+ public static final String S3GUARD_CONSISTENCY_RETRY_INTERVAL =
+ "fs.s3a.s3guard.consistency.retry.interval";
+
+ /**
+ * Default initial retry interval: {@value}.
Review comment:
Maybe (really, just maybe, so you don't have to if you don't think that's
needed) add as a comment that `An exponential back-off is used here: every
failure doubles the delay.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
