steveloughran commented on a change in pull request #1442: HADOOP-16570. S3A 
committers leak threads on job/task commit.
URL: https://github.com/apache/hadoop/pull/1442#discussion_r326761254
 
 

 ##########
 File path: 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/AbstractS3ACommitter.java
 ##########
 @@ -742,6 +754,27 @@ protected final synchronized ExecutorService 
buildThreadPool(
     return threadPool;
   }
 
+  /**
+   * Destroy any thread pool; wait for it to finish,
+   * but don't overreact if it doesn't finish in time.
+   */
+  protected final synchronized void destroyThreadPool() {
 
 Review comment:
   No real reason

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to