[ 
https://issues.apache.org/jira/browse/HADOOP-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935196#comment-16935196
 ] 

Duo Zhang commented on HADOOP-16559:
------------------------------------

OK, got your point why we can not do it at once. Maybe it is time to separate 
the hadoop project to several sub projects, another story.

Left some comments on the PR for HADOOP-16558. PTAL.

And here, since this is not a trivial change, I suggest we revert HADOOP-16557 
first? Now it is a pain for developpers as we need protobuf 3.7.1 to compile 
trunk and then 2.5.0 to compile other branches...

Once we get the new plugin done for all active branches, we can re apply 
HADOOP-16557, and we do not need to install protoc compiler in the docker image 
any more.

What do you think? [~vinayakumarb]

Thanks.

> [HDFS] use protobuf-maven-plugin to generate protobuf classes
> -------------------------------------------------------------
>
>                 Key: HADOOP-16559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16559
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinayakumar B
>            Assignee: Duo Zhang
>            Priority: Major
>
> Use "protoc-maven-plugin" to dynamically download protobuf executable to 
> generate protobuf classes from proto file



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to