vinayakumarb commented on a change in pull request #1496: HADOOP-16560. [YARN + MAPREDUCE] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#discussion_r326914809
########## File path: hadoop-project/pom.xml ########## @@ -1715,9 +1715,56 @@ <artifactId>frontend-maven-plugin</artifactId> <version>${frontend-maven-plugin.version}</version> </plugin> + <plugin> + <groupId>org.xolstice.maven.plugins</groupId> + <artifactId>protobuf-maven-plugin</artifactId> + <version>${protobuf-maven-plugin.version}</version> + <extensions>true</extensions> + <configuration> + <protocArtifact> + com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier} + </protocArtifact> + <attachProtoSources>false</attachProtoSources> + </configuration> + <executions> + <execution> + <id>src-compile-protoc</id> + <phase>generate-sources</phase> + <goals> + <goal>compile</goal> + </goals> + <configuration> + <includeDependenciesInDescriptorSet>false</includeDependenciesInDescriptorSet> Review comment: in #1494 this execution is made to skip by default. Reason is, every module can specifically enable this execution whenever required. Anyway every module needs to provide specific dependency information. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org