hadoop-yetus commented on a change in pull request #1515: HDDS-2171. Dangling links in test report due to incompatible realpath URL: https://github.com/apache/hadoop/pull/1515#discussion_r327758756
########## File path: hadoop-ozone/dev-support/checks/_mvn_unit_report.sh ########## @@ -16,6 +16,15 @@ REPORT_DIR=${REPORT_DIR:-$PWD} +_realpath() { + if realpath "$@" > /dev/null; then + realpath "$@" + else + local relative_to=$(realpath "${1/--relative-to=/}") Review comment: shellcheck:11: warning: Declare and assign separately to avoid masking return values. [SC2155] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org