anuengineer commented on a change in pull request #1513: HDDS-2149. Replace
FindBugs with SpotBugs
URL: https://github.com/apache/hadoop/pull/1513#discussion_r327759427
##########
File path: hadoop-ozone/dev-support/checks/findbugs.sh
##########
@@ -16,16 +16,15 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
-mvn -B compile -fn findbugs:check -Dfindbugs.failOnError=false -f
pom.ozone.xml
+mvn -B compile -fn spotbugs:check -Dspotbugs.failOnError=false -f pom.ozone.xml
Review comment:
should this be spotbugs:check or spotbugs:spotbugs ?? The spotbugs:check
does not produce the report
Please look at the table in this link.
https://spotbugs.github.io/spotbugs-maven-plugin/plugin-info.html
Just wondering if it makes sense to save the report at all .. ? this is more
of a question, than informed opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
