ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs
while mounting external store
URL: https://github.com/apache/hadoop/pull/1478#discussion_r328767391
##########
File path:
hadoop-tools/hadoop-fs2img/src/main/java/org/apache/hadoop/hdfs/server/namenode/UGIResolver.java
##########
@@ -132,4 +138,134 @@ public FsPermission permission(FileStatus s) {
return s.getPermission();
}
+ private long resolve(AclStatus aclStatus) {
+ return buildPermissionStatus(
+ user(aclStatus), group(aclStatus), permission(aclStatus).toShort());
+ }
+
+ /**
+ * Get the locally mapped user for external {@link AclStatus}.
+ *
+ * @param aclStatus AclStatus on external store.
+ * @return locally mapped user name.
+ */
+ public String user(AclStatus aclStatus) {
Review comment:
The user mapping behavior can be different in a subclass. For e.g. In this
case `SingleUGIResolver` maps all users to a single user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
