nandakumar131 commented on a change in pull request #1540: HDDS-2198. SCM
should not consider containers in CLOSING state to come out of safemode.
URL: https://github.com/apache/hadoop/pull/1540#discussion_r330715763
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/ContainerSafeModeRule.java
##########
@@ -63,19 +64,17 @@ public ContainerSafeModeRule(String ruleName, EventQueue
eventQueue,
" value should be >= 0.0 and <= 1.0");
containerMap = new ConcurrentHashMap<>();
- if(containers != null) {
- containers.forEach(c -> {
- // TODO: There can be containers in OPEN state which were never
- // created by the client. We are not considering these containers for
- // now. These containers can be handled by tracking pipelines.
- if (c != null && c.getState() != null &&
- !c.getState().equals(HddsProtos.LifeCycleState.OPEN)) {
- containerMap.put(c.getContainerID(), c);
- }
- });
- maxContainer = containerMap.size();
- }
-
+ containers.forEach(container -> {
Review comment:
`ContainerManager.getContainers()` doesn't return null, it returns empty
list if there are no containers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
