[
https://issues.apache.org/jira/browse/HADOOP-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950908#comment-16950908
]
Adam Antal commented on HADOOP-16510:
-------------------------------------
Uploaded patchset v2 - fixing checkstyle and failed tests.
Also, a short notice to everyone: patch v1 introduced a timeout in
{{TestLightWeightResizableGSet}} because {{assertThat$contains}} does not
default to {{Iterable$contains}}, it uses a stream-filter on
object-collect-assertNotEmpty solution which is *very* inefficient (thus the
timeout) - also that would not test the behaviour of the
{{LightWeightResizableGSet}} anyways. Fixed all of this in patchset v2.
> [hadoop-common] Fix order of actual and expected expression in assert
> statements
> --------------------------------------------------------------------------------
>
> Key: HADOOP-16510
> URL: https://issues.apache.org/jira/browse/HADOOP-16510
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: HADOOP-16510.001.patch, HADOOP-16510.002.patch
>
>
> Fix order of actual and expected expression in assert statements which gives
> misleading message when test case fails. Attached file has some of the places
> where it is placed wrongly.
> {code:java}
> [ERROR]
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
> Time elapsed: 3.385 s <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be
> used for new test cases which avoids such mistakes.
> This is a follow-up jira for the hadoop-common project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
