adoroszlai commented on a change in pull request #1622: HDDS-1228. Chunk
Scanner Checkpoints
URL: https://github.com/apache/hadoop/pull/1622#discussion_r334630866
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerDataScanner.java
##########
@@ -95,14 +97,19 @@ public void runIteration() {
while (!stopping && itr.hasNext()) {
Container c = itr.next();
if (c.shouldScanData()) {
+ ContainerData containerData = c.getContainerData();
+ long containerId = containerData.getContainerID();
try {
+ logScanStart(containerData);
if (!c.scanData(throttler, canceler)) {
metrics.incNumUnHealthyContainers();
- controller.markContainerUnhealthy(
- c.getContainerData().getContainerID());
+ controller.markContainerUnhealthy(containerId);
Review comment:
I would avoid this for two reasons:
1. The full scan includes a scan of the metadata, too, and the failure may
be due to metadata problem. Eg. if the `.container` file is missing or invalid
etc. In that case we cannot update the timestamp in the file.
2. Unhealthy containers are skipped during further iterations, so the
timestamp would not make much difference anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
