steveloughran commented on a change in pull request #1664: HADOOP-16658 - S3A
connector does not support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#discussion_r337633900
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/delegation/TestS3ADelegationTokenSupport.java
##########
@@ -110,13 +116,34 @@ public void testSessionTokenIdentifierRoundTrip() throws
Throwable {
assertEquals("credentials in " + ids,
id.getMarshalledCredentials(),
result.getMarshalledCredentials());
+ assertEquals(renewer, id.getRenewer());
+ }
+
+ @Test
+ public void testSessionTokenIdentifierRoundTripNoRenewer() throws Throwable {
+ SessionTokenIdentifier id = new SessionTokenIdentifier(
+ SESSION_TOKEN_KIND,
+ new Text(),
+ null,
+ landsatUri,
+ new MarshalledCredentials("a", "b", "c"),
+ new EncryptionSecrets(), "");
+
+ SessionTokenIdentifier result = S3ATestUtils.roundTrip(id, null);
+ String ids = id.toString();
+ assertEquals("URI in " + ids, id.getUri(), result.getUri());
+ assertEquals("credentials in " + ids,
+ id.getMarshalledCredentials(),
+ result.getMarshalledCredentials());
+ assertEquals(new Text(), id.getRenewer());
Review comment:
add message `"renewer in " + ids`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
