steveloughran commented on issue #1614: HADOOP-16615. Add password check for credential provider URL: https://github.com/apache/hadoop/pull/1614#issuecomment-545526777 I like all tests in our code to provide enough diagnostics on failure that we can work out what went wrong purely from the Jenkins logs. AssertJ is really good here, which is why we are adopting it in new code. For your tests, I'm going to propose a new assertion which can be used to validate the output of the new command. If the condition is not met, The exception raised will include all of the output. ``` private void assertOutputContains(String expected) { Assertions.assertThat(outContent.toString()) .contains(expected)); } ``` Yetus probably isn't retesting the code, as it thinks the last change was a documentation only change. If you change the test case things may be different.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
