steveloughran commented on a change in pull request #1640: HADOOP-16637. Fix
findbugs warnings in hadoop-cos.
URL: https://github.com/apache/hadoop/pull/1640#discussion_r338152515
##########
File path:
hadoop-cloud-storage-project/hadoop-cos/src/main/java/org/apache/hadoop/fs/cosn/CosNativeFileSystemStore.java
##########
@@ -249,7 +250,15 @@ public void storeEmptyFile(String key) throws IOException
{
public PartETag uploadPart(File file, String key, String uploadId,
int partNum) throws IOException {
- InputStream inputStream = new FileInputStream(file);
+ InputStream inputStream = null;
Review comment:
looks broken, as L262 will always get a closed stream
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
