goiri commented on a change in pull request #1611: HADOOP-16612 Track Azure
Blob File System client-perceived latency
URL: https://github.com/apache/hadoop/pull/1611#discussion_r338704457
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java
##########
@@ -161,6 +163,44 @@ public String toString() {
return sb.toString();
}
+ // Returns a trace message for the ABFS API logging service to consume
+ public String toKvpString() {
+ String urlStr = null;
+
+ try{
+ urlStr = URLEncoder.encode(url.toString(), "UTF-8");
+ } catch(UnsupportedEncodingException e) {
+ urlStr = "https%3A%2F%2Ffailed%2Fto%2Fencode%2Furl";
+ }
+
+ final StringBuilder sb = new StringBuilder();
+ sb.append("s=");
Review comment:
do:
final StringBuilder sb = new StringBuilder()
.append("s=")
.append(statusCode)
.append(" e=")
....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
