jojochuang commented on a change in pull request #1667: HDFS-14308.
DFSStripedInputStream curStripeBuf is not freed by unbuff…
URL: https://github.com/apache/hadoop/pull/1667#discussion_r338883378
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedInputStream.java
##########
@@ -554,4 +555,17 @@ public synchronized void releaseBuffer(ByteBuffer buffer)
{
throw new UnsupportedOperationException(
"Not support enhanced byte buffer access.");
}
+
+ @Override
+ public synchronized void unbuffer() {
+ closeCurrentBlockReaders();
Review comment:
Overall looks good. Just one nit.
Could you call super.unbuffer() instead?
+1 after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
