steveloughran commented on a change in pull request #1702: HDFS-14788 Use
dynamic regex filter to ignore copy of source files in…
URL: https://github.com/apache/hadoop/pull/1702#discussion_r345775604
##########
File path:
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyFilter.java
##########
@@ -47,13 +53,29 @@ public void initialize() {}
* @return An instance of the appropriate CopyFilter
*/
public static CopyFilter getCopyFilter(Configuration conf) {
+ String filtersClassName =
conf.get(DistCpConstants.CONF_LABEL_FILTERS_CLASS);
Review comment:
ok, I see you've moved there. Looks better. One issue I'll cover separately
is about what exceptions can we raise from this class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
