[ https://issues.apache.org/jira/browse/HADOOP-16718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978870#comment-16978870 ]
Wei-Chiu Chuang edited comment on HADOOP-16718 at 11/21/19 12:54 AM: --------------------------------------------------------------------- Is there a way to unit test it? I assume not. was (Author: jojochuang): Is there a way to unit test it? I assume not. Please also update core-default.xml and add the description there. > Allow disabling Server Name Indication (SNI) for Jetty > ------------------------------------------------------ > > Key: HADOOP-16718 > URL: https://issues.apache.org/jira/browse/HADOOP-16718 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 3.2.1 > Reporter: Siyao Meng > Assignee: Aravindan Vijayan > Priority: Major > Attachments: HADOOP-16718-branch-3.2-v000.patch > > > As of now, {{createHttpsChannelConnector()}} enables SNI by default with > Jetty: > {code} > private ServerConnector createHttpsChannelConnector( > Server server, HttpConfiguration httpConfig) { > httpConfig.setSecureScheme(HTTPS_SCHEME); > httpConfig.addCustomizer(new SecureRequestCustomizer()); > ServerConnector conn = createHttpChannelConnector(server, httpConfig); > {code} > with the default constructor without any parameters automatically setting > {{sniHostCheck}} to {{true}}: > {code} > public SecureRequestCustomizer() > { > this(true); > } > {code} > Proposal: We should make this configurable and probably default this to false. > Credit: Aravindan Vijayan -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org