steveloughran commented on issue #1712: HADOOP-16699: Adding verbose TRACE logging URL: https://github.com/apache/hadoop/pull/1712#issuecomment-559143920 If you are actually trying to debug the behaviour of plug-in components I would prefer that you embrace `org.apache.hadoop.util.DurationInfo` which can you log out in fellow debug at the start and end of all operations, and calculates actual durations -which is handy example use ```java try (DurationInfo d = new DurationInfo(LOG, false, "Waiting for task completion")) { future.join(); } catch (CompletionException e) { raiseInnerCause(e); } ``` No matter the code flow, information will get logged. With your current patch if there is a failure nobody sees it. You've been working here, if you're happy with it: fine. However, you can do more and for all your future patches I will be expecting it. So: let me know what you want to do here? 1. Merge in as is 2. Explore DurationInfo Your choice.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
