DadanielZ commented on a change in pull request #452: HADOOP-16005: Add XAttr
support to WASB and ABFS
URL: https://github.com/apache/hadoop/pull/452#discussion_r351542440
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/NativeAzureFileSystemBaseTest.java
##########
@@ -117,6 +124,70 @@ public void testStoreRetrieveFile() throws Exception {
fs.delete(testFile, true);
}
+ @Test
+ public void testSetGetXAttr() throws Exception {
+ byte[] attributeValue1 = "hi".getBytes(StandardCharsets.UTF_8);
+ byte[] attributeValue2 = "你好".getBytes(StandardCharsets.UTF_8);
+ String attributeName1 = "user.asciiAttribute";
+ String attributeName2 = "user.unicodeAttribute";
+ Path testFile = methodPath();
+
+ // after creating a file, the xAttr should not be present
+ createEmptyFile(testFile,
FsPermission.createImmutable(READ_WRITE_PERMISSIONS));
+ assertNull(fs.getXAttr(testFile, attributeName1));
+
+ // after setting the xAttr on the file, the value should be retrievable
+ fs.setXAttr(testFile, attributeName1, attributeValue1);
+ assertArrayEquals(attributeValue1, fs.getXAttr(testFile, attributeName1));
+
+ // after setting a second xAttr on the file, the first xAttr values should
not be overwritten
+ fs.setXAttr(testFile, attributeName2, attributeValue2);
+ assertArrayEquals(attributeValue1, fs.getXAttr(testFile, attributeName1));
+ assertArrayEquals(attributeValue2, fs.getXAttr(testFile, attributeName2));
+ }
+
+ @Test
+ public void testSetGetXAttrCreateReplace() throws Exception {
+ byte[] attributeValue = "one".getBytes(StandardCharsets.UTF_8);
+ String attributeName = "user.someAttribute";
+ Path testFile = methodPath();
+
+ // after creating a file, it must be possible to create a new xAttr
+ createEmptyFile(testFile,
FsPermission.createImmutable(READ_WRITE_PERMISSIONS));
+ fs.setXAttr(testFile, attributeName, attributeValue, CREATE_FLAG);
+ assertArrayEquals(attributeValue, fs.getXAttr(testFile, attributeName));
+
+ // however after the xAttr is created, creating it again must fail
+ try {
+ fs.setXAttr(testFile, attributeName, attributeValue, CREATE_FLAG);
+ fail("Creating an existing xAttr should fail");
Review comment:
you can use "org.apache.hadoop.test.LambdaTestUtils.intercept" for exception
check, here and in other files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
