Mingliang Liu created HADOOP-16757:
--------------------------------------

             Summary: Increase timeout unit test rule for 
ITestDynamoDBMetadataStore
                 Key: HADOOP-16757
                 URL: https://issues.apache.org/jira/browse/HADOOP-16757
             Project: Hadoop Common
          Issue Type: Sub-task
            Reporter: Mingliang Liu


Not sure if this is a good proposal, but I saw a few cases where some 
integration test methods in {{ITestDynamoDBMetadataStore}} timed out simply. 
Specially, the one keeps failing me today is {{testAncestorOverwriteConflict}}. 
I increase the timeout to 20s and it works for me happily. Am I using VPN and a 
slow home network, I'm afraid so.

The time out rule, as inherited from base class {{HadoopTestBase}}, is 10s by 
default. Though that 10s time out default value can be overridden in base class 
via system property {{test.default.timeout}}, that's system wide affecting all 
other tests. Changing that time out value for one test is no better than 
overriding in this test {{ITestDynamoDBMetadataStore}} explicitly. I think 
doubling it to 20s would not be very crazy considering we are testing against a 
remote web service, create and destroy tables sometimes.

{code}
  @Rule
  public Timeout timeout = new Timeout(20 * 1000);
{code}

Thoughts?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to